D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

Stefan BrĂ¼ns noreply at phabricator.kde.org
Thu Jul 5 17:54:27 BST 2018


bruns added inline comments.

INLINE COMMENTS

> file.cpp:909
>           * and it has a default ACL, also append that. */
>          appendACLAtoms(path, entry, type);
>      }

For UDS_ACCESS, _USER, _GROUP, we follow the symlink (i.e use the corresponding buff), for ACL we do not?

> file.cpp:913
>  
> -notype:
>      if (details > 0) {
> +        entry.fastInsert(KIO::UDSEntry::UDS_MODIFICATION_TIME, buff.st_mtime);

all the fields below are pointless in case of isBrokenSymlink, buff may contain anything after the failed stat call.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13898

To: jtamate, dfaure, #frameworks
Cc: bruns, kde-frameworks-devel, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180705/7e87c2c7/attachment.html>


More information about the Kde-frameworks-devel mailing list