D13808: Fix KMainWindow saving incorrect widget settings
Mladen Milinkovic
noreply at phabricator.kde.org
Thu Jul 5 16:51:12 BST 2018
maxrd2 added inline comments.
INLINE COMMENTS
> broulik wrote in kmainwindow_unittest.cpp:267
> `mw->deleteLater()`?
tried it too... will retry all of them again with isHidden()
> broulik wrote in kmainwindow_unittest.cpp:278
> `QCOMPARE(mw->m-dock->isVisible(), true)`
mmm.. sorry i was supposed to use isHidden() test here, isVisible() is not the opposite
will change to QCOMPARE(mw->m-dock->isHidden(), false)
REPOSITORY
R263 KXmlGui
BRANCH
fix-window-state-save
REVISION DETAIL
https://phabricator.kde.org/D13808
To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: wbauer, aacid, ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180705/4a8175b1/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list