D13899: KMessageWidget: use theme instead of hardcoded colours

Albert Astals Cid noreply at phabricator.kde.org
Thu Jul 5 15:23:47 BST 2018


aacid added a comment.


  I know the class is not exported, but having it be "const correct" is always nice :)

INLINE COMMENTS

> kthemesettings_p.h:66
> +     */
> +    bool isValid();
> +

const?

> kthemesettings_p.h:71
> +     */
> +    bool contains(const QString &key);
> +

const?

> kthemesettings_p.h:76
> +     */
> +    QStringList childGroups();
> +

const?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D13899

To: rjvbb, #frameworks, #vdg
Cc: aacid, broulik, kde-frameworks-devel, michaelh, crozbo, firef, ngraham, bruns, skadinna, aaronhoneycutt, mbohlender
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180705/be52b5b0/attachment.html>


More information about the Kde-frameworks-devel mailing list