D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

David Faure noreply at phabricator.kde.org
Thu Jul 5 11:50:20 BST 2018


dfaure added inline comments.

INLINE COMMENTS

> file.cpp:880
>              // A symlink -> follow it only if details>1
>              if (details > 1 && QT_STAT(path.constData(), &buff) == -1) {
> +                isSymLink = true;

BTW the point is that we follow the link (by filling "buff" with this QT_STAT call), but then we also check that call for errors: if it returned -1, then the link is broken.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13898

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180705/11e1be4b/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list