D13898: Use non deprecated fastInsert in file.cpp (first of many to come)
Jaime Torres Amate
noreply at phabricator.kde.org
Thu Jul 5 10:12:26 BST 2018
jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.
REVISION SUMMARY
Avoid the goto using local variables.
Use fastInsert instead of insert.
NOTE: In this case the comments are confusing, is it a symbolic link or a broken symbolic link?
NOTE: Does make sense to have ACLs for a (broken) symbolic link?
TEST PLAN
The tests pass.
Dolphin works with broken symbolic links.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D13898
AFFECTED FILES
src/ioslaves/file/file.cpp
To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180705/68424d2d/attachment.html>
More information about the Kde-frameworks-devel
mailing list