D13895: Fix off by one error in Cache::clear

David Edmundson noreply at phabricator.kde.org
Thu Jul 5 00:48:41 BST 2018


davidedmundson created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  beginRemoveRows args are int first, int last
  
  i.e If you have 1 entry you should be calling
  beginRemoveRows(0, 0);
  
  BUG: 396175

TEST PLAN
  Code review of a common mistake
  Other usages in the same code were fine

REPOSITORY
  R159 KActivities Statistics

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13895

AFFECTED FILES
  src/resultmodel.cpp

To: davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180704/8a93d05f/attachment.html>


More information about the Kde-frameworks-devel mailing list