D13869: [solid] Notify when interface to mounted fs is lost

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> bruns wrote in udisksmanager.cpp:220
> This code needs some restructuring, and with the additional conditions, some comments ...
> 
> 1. `if (udi.isEmpty()) return;`
> 2. you are whitelisting a lot of conditions (`... || .. || ...`) - are the any cases left where the signal is **not** emitted?

According to docs, https://dbus.freedesktop.org/doc/dbus-specification.html#standard-interfaces-objectmanager, interfaces should not be empty but a dict of looses ones.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D13869

To: anthonyfieroni, broulik, cfeck, dfaure
Cc: bruns, kde-frameworks-devel, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180704/7237052b/attachment.html>