D13814: Speedup sort
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Mon Jul 2 11:44:23 BST 2018
bruns added a comment.
In D13814#286034 <https://phabricator.kde.org/D13814#286034>, @jtamate wrote:
> > In other words, the fix for that can probably be removed now.
>
> I prefer not to do it (even I've tried without any crash), because QVariant is not even reentrant.
Reentrancy is only relevant when the class has some global state.
Anyway, it is indepedent and should go in a separate review.
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D13814
To: jtamate, #dolphin, #frameworks
Cc: apol, bruns, markg, kfm-devel, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180702/62f257c0/attachment.html>
More information about the Kde-frameworks-devel
mailing list