D13814: Speedup sort

[Mark Gaiser]

markg added a comment.


  In D13814#285686 <https://phabricator.kde.org/D13814#285686>, @bruns wrote:
  
  > In D13814#285660 <https://phabricator.kde.org/D13814#285660>, @markg wrote:
  >
  > > > I don't know if that's still an issue or if your patch re-introduces whatever the problem was (race conditions?). You could look back in the commit log when that was added to figure out more about it.
  > >
  > > To answer that myself, it was done in this commit: https://cgit.kde.org/dolphin.git/commit/src/kitemviews/kfileitemmodel.cpp?id=d9680ead8099df9a2b06bfed61a62923778996f2
  > >  And doesn't explain anything :)
  >
  >
  > If you follow the link in the comment, i.e. https://bugs.kde.org/show_bug.cgi?id=312679, it mentions date sorting and KDateTime being non-reentrant.
  
  
  That would be really interesting as KDateTime isn't used anywhere in Dolphin anymore (according to my grep on the source). It's all QDateTime now and that is all reentrant according to the Qt docs!
  In other words, the fix for that can probably be removed now.
  
  Just an assumption though. I haven't tried anything.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13814

To: jtamate, #dolphin, #frameworks
Cc: bruns, markg, kfm-devel, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180701/08d87afe/attachment.html>