D10203: baloo:DocumentUrlDB: Temporarily remove Q_ASSERT, ignore empty filenames instead

Michael Heidelbach noreply at phabricator.kde.org
Wed Jan 31 15:40:18 UTC 2018


michaelh created this revision.
michaelh added reviewers: dfaure, vhanda, Frameworks.
Restricted Application added a project: Frameworks.
michaelh requested review of this revision.

REVISION SUMMARY
  In debug mode this assert prevents usage of cli tools like baloosearch.
  Replace Q_ASSERT with an if.. clause until the cause for assert failure is clear

TEST PLAN
    $baloosearch type:Audio | grep '^$' | wc -l
    17
  
  + 17 lines on stderr "Id  148657949215033349  has no valid filename, ignoring it."
  
  baloosearch://?query=type:Audio in dolphin looks normal.

REPOSITORY
  R293 Baloo

BRANCH
  empty-file

REVISION DETAIL
  https://phabricator.kde.org/D10203

AFFECTED FILES
  src/engine/documenturldb.cpp

To: michaelh, dfaure, vhanda, #frameworks
Cc: michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180131/0faeebcb/attachment.html>


More information about the Kde-frameworks-devel mailing list