D9672: Don't emit error signal before we tried all list commands.

Christoph Feck noreply at phabricator.kde.org
Wed Jan 31 00:51:33 UTC 2018


cfeck added a comment.


  Sorry for the late response, but we currently have no maintainer for the FTP code in KIO.
  
  From quickly checking, the intention looks good, but if the ERR_* codes are part of an enum, maybe add the special value -1 with a name there, instead of hardcoding the -1 value? It might even fail with compilers that strictly treat enum's as a separate data type.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9672

To: wcpan, dfaure
Cc: cfeck, #frameworks, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180131/9b43356b/attachment.html>


More information about the Kde-frameworks-devel mailing list