D10113: baloo-widgets: Emit metaDataRequestFinished once per request

Michael Heidelbach noreply at phabricator.kde.org
Tue Jan 30 17:20:36 UTC 2018


michaelh added a comment.


  Both test for empty failed because the spy timed out!
  IMO they should not, because consumers rely on the `metaDataRequestFinished` signal.
  Please tell me if you disagree.
  
  I don't know why they fail, yet. Because line 371 is reached in src/filemetadataprovider.cpp <https://phabricator.kde.org/D10113#change-moyZ89ZQ9veK>.
  
    370    if (items.isEmpty()) {
    371	​        emit loadingFinished();

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10113

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks
Cc: dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180130/839eafc9/attachment.html>


More information about the Kde-frameworks-devel mailing list