D10113: baloo-widgets: Emit metaDataRequestFinished once per request
Elvis Angelaccio
noreply at phabricator.kde.org
Mon Jan 29 21:18:04 UTC 2018
elvisangelaccio added inline comments.
INLINE COMMENTS
> michaelh wrote in filemetadataprovider.cpp:323
> In that case it might be safer to do
>
> IndexedDataRetriever *ret = new IndexedDataRetriever(filePath, this);
> connect(ret, SIGNAL(finished(KJob*)), this, SLOT(slotLoadingFinished(KJob*)));
>
> insertBasicData();
> insertEditableData();
> emit dataAvailable();
>
> ret->start();
>
> Because once loadingFinished() is signalled it's over. dataAvailable(); won't get processed anymore.
Sounds good, but please explain why we are moving this signal in the commit message. This will make easier to `git blame` this code in the future.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D10113
To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks
Cc: dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180129/df1487e3/attachment.html>
More information about the Kde-frameworks-devel
mailing list