D10168: Use nullptr for passing a null pointer to crc32

Albert Astals Cid noreply at phabricator.kde.org
Sun Jan 28 21:30:16 UTC 2018


aacid created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
aacid requested review of this revision.

REVISION SUMMARY
  I'm a bit unconvinced, wihtout it we get a warning if we enable -Wzero-as-null-pointer-constant
  but using Z_NULL seems to be more "what the library wants"
  
  If we don't want this, this would be a reason against enabling -Wzero-as-null-pointer-constant
  for all the frameworks as i've suggested in the other review

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10168

AFFECTED FILES
  src/kgzipfilter.cpp
  src/kzip.cpp

To: aacid
Cc: #frameworks, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180128/5976c3ae/attachment.html>


More information about the Kde-frameworks-devel mailing list