D10135: Put built-in holiday definitions into qrc
Dominik Haumann
noreply at phabricator.kde.org
Sun Jan 28 11:17:07 UTC 2018
dhaumann added a comment.
I'm late to the game, but in general looks good.
Minor comments:
- What's missing (or I miss something) is that it could be that entries exist twice, if in resource and on disk. Since this is not the case right now, this is probably not an issue.
- holidays/holidays.qrc is manually maintained and not auto-generated. This is probably fine as well since we don't expect as many changes as e.g. in the syntax-highlighting repo...
REPOSITORY
R175 PIM: KHolidays
REVISION DETAIL
https://phabricator.kde.org/D10135
To: vkrause, #frameworks, #kde_pim, mlaurent
Cc: dhaumann, mlaurent, dvasin, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180128/62badf12/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list