D10136: AppArmor: new keywords, improvements & fixes

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks good and test passes. Just one minor comment that is not really relevant for now - will push in a second.

INLINE COMMENTS

> apparmor.xml:709
>  				<keyword context="_profile_name" attribute="Profile Head" String="profile_head"/>
> -				<RegExpr context="_profile_name" attribute="Profile Head" String="(\s|^\s*)\^(?=\S)"/>			
> +				<RegExpr context="_profile_name" attribute="Profile Head" String="(^|\s)\^(?=\S)"/>
>  				<keyword context="#stay" attribute="Option" String="profile_options"/>

Are you looking for \b when using (^|\s) ? Or maybe even for firstNonSpace="true" ?

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  apparmor-v4 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10136

To: nibags, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, #framework_syntax_highlighting, #frameworks, michaelh, genethomas, cullmann, vkrause
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180128/0b56f8db/attachment.html>