D10124: Faster simplejob start

[Jaime Torres Amate]

jtamate updated this revision to Diff 26109.
jtamate added a comment.


  Reverting to first patch.
  
  The lambda syntax has some problems with private d_func pointers under dolphin
  
  Thread 1 "dolphin" received signal SIGSEGV, Segmentation fault.
  0x00007ffff21b5b4c in KJob::d_func (this=0x4000000000000000) at /g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.h:651
  651         Q_DECLARE_PRIVATE(KJob)
  (gdb) where
  #0  0x00007ffff21b5b4c in KJob::d_func (this=0x4000000000000000) at /g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.h:651
  #1  0x00007ffff21b3a77 in KJob::totalAmount (this=0x4000000000000000, unit=KJob::Bytes) at /g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.cpp:235
  #2  0x00007ffff39a22f3 in KIO::SimpleJobPrivate::slotTotalSize (this=0xd4de80, size=2097152) at /g/5kde/frameworks/kio/src/core/simplejob.cpp:268
  #3  0x00007ffff39a1332 in KIO::SimpleJobPrivate::<lambda(KIO::filesize_t)>::operator()(KIO::filesize_t) const (__closure=0xdd0bc0, size=2097152)
  
    at /g/5kde/frameworks/kio/src/core/simplejob.cpp:153
  
  #4  0x00007ffff39a4120 in QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<long long unsigned int>, void, KIO::SimpleJobPrivate::start(KIO::Slave*)::<lambda(KIO::filesize_t)> >::call(KIO::SimpleJobPrivate::<lambda(KIO::filesize_t)> &, void **) (f=..., arg=0x7fffffffcc50)
  
    at /usr/include/qt5/QtCore/qobjectdefs_impl.h:130

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10124?vs=26047&id=26109

BRANCH
  start (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10124

AFFECTED FILES
  src/core/simplejob.cpp

To: jtamate, #frameworks
Cc: broulik, ngraham, anthonyfieroni, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180128/a9035790/attachment.html>