D10145: Improve line height

[Christoph Cullmann]

cullmann created this revision.
cullmann added a reviewer: KTextEditor.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
cullmann requested review of this revision.

REVISION SUMMARY
  I played a bit more with KTextEditor on macOS.
  It seems we are too restrictive what we use as line height.
  The attached patch increases the height by the leading, both in the computation in the renderer for line height + layouting.
  
  I still get some artifacts like in https://bugs.kde.org/show_bug.cgi?id=379727
  
  But I think that is more likely some rendering mis-shape in Qt itself, as you get even artifacts vertically inside a line during the drawing...

TEST PLAN
  For me, less overlapping of lines occur in different zoom variants.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D10145

AFFECTED FILES
  src/render/katerenderer.cpp

To: cullmann, #ktexteditor
Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180127/7df13bbb/attachment.html>