D10113: baloo-widgets: Emit metaDataRequestFinished once per request

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> filemetadataprovider.h:114
>      void loadingFinished();
> +    void dataAvailable();
>  

Could you add API documentation there what this signal indicates and when to use it? Typically, if you find code that is documented it is good practice to do the same :-)

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10113

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks
Cc: dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180127/db963901/attachment.html>