D9966: [KIO] Fix issues with sharing of file descriptor

Chinmoy Ranjan Pradhan noreply at phabricator.kde.org
Sat Jan 27 09:38:20 UTC 2018


chinmoyr marked an inline comment as done.
chinmoyr added inline comments.

INLINE COMMENTS

> fvogt wrote in sharefd_p.h:66
> If that is the case you can do something like:
> 
>   #if !defined(__linux__) && !defined(__FreeBSD__)
>   #error No secure implementation available
>   #endif

I think this is not needed. It's already there in FdReceiver.

> sharefd_p.h:47
>      {
> -        return sizeof addr;
> +        return offsetof(struct sockaddr_un, sun_path) + strlen(addr.sun_path);
>      }

@fvogt Is +1 for null byte required here?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9966

To: chinmoyr, #frameworks, thiago, fvogt
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180127/ef7c4c33/attachment.html>


More information about the Kde-frameworks-devel mailing list