D10124: Faster simplejob start

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> simplejob.cpp:142
>  
>      q->connect(slave, SIGNAL(infoMessage(QString)),
>                 SLOT(_k_slotSlaveInfoMessage(QString)));

Try something along the lines of

  q->connect(slave, &Slave::infoMessage, q, std::bind(&SimpleJobPrivate::_k_slotSlaveInfoMessage, this);

Note that if there's a `disconnect` for that particular signal somewhere in the code this will not work but at a quick glance I can only see a `disconnect(m_slave);` which is fine

`QObject::connect` is static, so you might as well do `QObject::connect` instead of `q->connect`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10124

To: jtamate, #frameworks
Cc: broulik, ngraham, anthonyfieroni
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180126/f4285da8/attachment.html>