D10077: [Default Tooltip] Fix sizing
Kai Uwe Broulik
noreply at phabricator.kde.org
Wed Jan 24 14:58:11 UTC 2018
broulik created this revision.
broulik added reviewers: Plasma, VDG.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Unset the Label's default height which completely confuses the renderer either shifting the item vertically (e.g. when toggling system tray popup), or letting it get too wide (e.g. when moving from a two-line tooltip to a one-line tooltip).
BUG: 386260
BUG: 389371
TEST PLAN
- Opened and closed System Tray popup, tooltip was correctly aligned now (bug 389371)
F5672178: Screenshot_20180124_155427.png <https://phabricator.kde.org/F5672178>
- Moved from NM to Battery plasmoid, tooltip was correctly sized now (bug 386260)
- Moved from task manager tooltip to kickoff and vice-versa, was still correct
- Observed all tooltips having a sane size.
When subtext linebreaks the tooltip can appear too wide because the word wrapped onto the next line but this isn't easily fisable, not without using a separate `TextMetrics` instance and other sledgehammer methods
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D10077
AFFECTED FILES
src/declarativeimports/core/private/DefaultToolTip.qml
To: broulik, #plasma, #vdg
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180124/7f824f6b/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list