D10071: Change an assert to do as the function documentation tells
David Faure
noreply at phabricator.kde.org
Wed Jan 24 12:26:21 UTC 2018
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Strange that the "bug report" mentions /d but the unittests doesn't have anything like that.
In fact, is it just me, or does the "extended" unittest pass without the fix? My testing seems to indicate that.
A good unittest for a bugfix has to *fail* without the fix applied ;)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10071
To: jtamate, #frameworks, dfaure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180124/15831c1a/attachment.html>
More information about the Kde-frameworks-devel
mailing list