D10071: Change an assert to do as the function documentation tells
Jaime Torres Amate
noreply at phabricator.kde.org
Wed Jan 24 11:34:27 UTC 2018
jtamate created this revision.
jtamate added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
jtamate requested review of this revision.
REVISION SUMMARY
Instead of an assert do as the documentation tells: return an invalid Url.
- In case both URLs are equal, an invalid URL is returned
TEST PLAN
How to assert:
In dolphin, in the location bar, change it into text and enter into one level directory from root, for example /d
When it changes into the breadcrum, press into the root one and crash (in Debug build).รง
I've been using this patch one month. And it doesn't affect the unit tests.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10071
AFFECTED FILES
src/filewidgets/urlutil_p.h
To: jtamate, #frameworks, dfaure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180124/13945bb5/attachment.html>
More information about the Kde-frameworks-devel
mailing list