D9983: Don't stat(/etc/localtime) between read() and write() copying files

[Jaime Torres Amate]

jtamate marked 3 inline comments as done.
jtamate added inline comments.

INLINE COMMENTS

> dfaure wrote in slavebase.cpp:1054
> Where does this "1" value come from, and it is useful at all?

It was 1 as could have been 0.
It is not needed anymore.

> dfaure wrote in slavebase.cpp:1055
> So when we go to that "else" branch, we'll have called start() and immediately after, invalidate(). To avoid doing this, how about calling start() in the first two if()s?
> (small optimization)

I was trying to save some code, but you're right. Here speed matters more than size.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9983

To: jtamate, #frameworks, dfaure
Cc: fvogt, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180124/a73c1ebf/attachment.html>