D10024: Add supportedSchemes feature

David Faure noreply at phabricator.kde.org
Wed Jan 24 08:30:01 UTC 2018


dfaure added inline comments.

INLINE COMMENTS

> kfilewidget.h:498
> +    /**
> +     * Set the URL schemes that the file widget should allow navigating to.
> +     *

All of these public methods should indicate that the default list is *empty* and that empty means "all schemes are supported".
I don't want to see people thinking they have to call this for anything to work, since that would only lead to unnecessarily limiting the amount of supported schemes in all cases where there's no reason to limit that.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10024

To: mwolff, #plasma, dfaure, mart
Cc: mart, apol, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180124/4eac51c8/attachment.html>


More information about the Kde-frameworks-devel mailing list