D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

René J.V. Bertin noreply at phabricator.kde.org
Tue Jan 16 11:24:17 UTC 2018


rjvbb added a comment.


  > But I won't write mega patches like you seem to prefer.
  
  I don't. They happen when it's more cumbersome than self-evident to go back and break up a new feature in baby-step components and justify adding them one at a time.
  
  > I try to keep things as minimal as possible. And I also can't give you an ETA or guarantee on when I'll fix the rest. This patch solves one big issues, and the added benchmark lies the foundation for future work. Let's start from here and get going.
  
  Agreed. It's a start, but if you can do the main 2 backends with (more or less) the same fix that'd be great. Apparently you rarely encounter the QFSW backend in your world anyway, so the risk should be small that applying a possibly suboptimal fix for that backend will satisfy you enough to let things rest there.
  On the contrary, someone who does use that backend all the time might realise that improvements were possible and step in.
  
  So please do measure the impact of your fix on performance with the QFSW backend.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9824

To: mwolff, dfaure, rjvbb, #kdevelop
Cc: markg, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180116/d07e5893/attachment.html>


More information about the Kde-frameworks-devel mailing list