D9888: Let kdesu work when __PATH_SU or __PATH_SUDO are not defined

[Milian Wolff]

mwolff added a comment.


  FTR:
  
    [13:35] <milian> how the hell can kdesu ever work? https://phabricator.kde.org/D9888 WTF
    [13:35] <milian> does anyone know if I'm missing something?
    [13:35] <milian> googling for these macros doesn't show me anything obvious either
    [13:53] <sitter> milian: dead code I'd say. note the `if` following your change checks if the file 'false' is exectuable (which it isn't as that'd be ./false which likely never exists) and then falls back to QSP::findExec(cmd). where cmd is macro'd to sudo or su depending on the cmake switch KDESU_USE_SUDO_DEFAULT
    [13:54] <milian> but it doesn't work for me without this patch
    [13:54] <milian> so it cannot be dead code :D
    [13:55] <milian> i.e. how can this work for anyone right now?
    [13:58] <sitter> milian: http://paste.debian.net/1005279/ is how I read the original
    [13:59] <milian> I'll see why this does not happen on my system
    [14:02] <sitter> milian: try this for good measure http://paste.debian.net/1005280/
    [14:02] <milian> yep
    [14:03] <sitter> mind you, it could be that __PATH_SU/SUDO is actually defined somewhere in a system level include which would then make the QT_ACCESS pass and break things
    [14:03] <milian> I can't find it in my  /usr/include at least
    [14:06] <milian> sitter: QT_ACCESS("false", X_OK) == 0 on my system
    [14:07] <milian> and no, there's no false in the current PWD
    [14:07] <milian> it's in /usr/bin though
    [14:07] <milian> I'd also be OK with removing that whole code and simplifying it
    [14:08] <milian> like you proposed

REPOSITORY
  R299 KDESu

REVISION DETAIL
  https://phabricator.kde.org/D9888

To: mwolff, dfaure, mpyne
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180115/50930718/attachment.html>