D9770: Optimization of byteSize(double size)

Milian Wolff noreply at phabricator.kde.org
Mon Jan 15 09:50:31 UTC 2018


mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.


  - do not ever profile a debug build, the results are completely bogus
  - do not use callgrind, use perf
  
  that said, I'm OK with this patch but the commit message should not talk about performance, but rather about code de-duplication. I doubt this has such a bit effect in a release build.

REPOSITORY
  R288 KJobWidgets

BRANCH
  performance (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9770

To: jtamate, #frameworks, mwolff
Cc: ngraham, cfeck, mwolff, broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180115/0a536475/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list