D9275: fix RTL appearance for ComboBox

Michail Vourlakos noreply at phabricator.kde.org
Sun Jan 14 09:30:31 UTC 2018


mvourlakos added a comment.


  In https://phabricator.kde.org/D9275#190594, @safaalfulaij wrote:
  
  > In https://phabricator.kde.org/D9275#190569, @mvourlakos wrote:
  >
  > > with your example me I cant reproduce it either...
  > >  I can only reproduce it with Latte Settings window, all other components are aligned correctly except the PlasmaComponent3.Combobox list items.
  > >
  > > you are right, this might be a downstream bug...
  > >
  > > Do you want to revert it 
  > >  I can do it
  >
  >
  > I checked out the source of latte-dock and it seems that it is using the old QQC1-based controls, which are problematic, especially with RTL :)
  >  This is a change for QQC2-based controls (version 3.0 of org.kde.plasma.components).
  
  
  To test it in Latte I added in the head of /shell/package/contents/configuration/AppearanceConfig.qml
  
    import org.kde.plasma.components 3.0 as PlasmaComponents3
  
  and I set up the ComboBox in that file to:
  
    PlasmaComponents3.ComboBox
  
  
  
  > But I can't understand how changing this V3 solved V2..
  
  V2 components are based totally at Qt Styles, V3 are reimplementing the behavior
  PlasmaComponents2.ComboBox is a ComboBoxStyle  but
  PlasmaComponents3.ComboBox is a real ComboBox

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9275

To: mvourlakos, #plasma, mart
Cc: safaalfulaij, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180114/6b9c12b9/attachment.html>


More information about the Kde-frameworks-devel mailing list