D9808: fix incorrect emission of signals by kLineEdit

Dan Weatherill noreply at phabricator.kde.org
Thu Jan 11 13:25:54 UTC 2018


dweatherill added inline comments.

INLINE COMMENTS

> dweatherill wrote in klineedit.cpp:184
> you are absolutely right! My mistake, I intended to rename it to textEdited, as this is what the signal we actually want to emit from QLineEdit is, and the name textEmitted is spurious.
> 
> I do think it should be renamed however, because the entire bug is that it should not be emitting textChanged in this case...

actually, reading more carefully, I agree it should not be renamed, just the spurious emission of textEdited should go

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D9808

To: dweatherill, #frameworks, dhaumann, cullmann
Cc: mwolff, dfaure, anthonyfieroni, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180111/3772abde/attachment.html>


More information about the Kde-frameworks-devel mailing list