D9781: do not incorrectly split spaces in paths of duplicate results
Harald Sitter
noreply at phabricator.kde.org
Wed Jan 10 09:33:07 UTC 2018
sitter created this revision.
sitter added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
sitter requested review of this revision.
REVISION SUMMARY
use kcoreaddons to split fdupes output. fdupes outputs
`/space\ inbetween/x.svg /space\ inbetween/y.svg`
as dupe result, which, if we split blindly for space, we'll split into 4
pieces instead of 2.
splitting the argument string using escape rules via kshell gives us
correct splitting by taking into account the escaped spaces.
unfortunately qregex doesn't seem to support negative lookbehind
expressions, or we could solve this with a `(?<!\\\\)` instead of having
to use kshell.
TEST PLAN
test output is lovely again
REPOSITORY
R266 Breeze Icons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9781
AFFECTED FILES
autotests/CMakeLists.txt
autotests/dupetest.cpp
To: sitter, dfaure
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180110/2608c8c6/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list