D9703: Allow applications using KActivities to not crash even if no dbus server is around

Christoph Cullmann noreply at phabricator.kde.org
Sat Jan 6 21:44:20 UTC 2018


cullmann created this revision.
cullmann added reviewers: Frameworks, KActivities.
Restricted Application added a project: Frameworks.
cullmann requested review of this revision.

REVISION SUMMARY
  Allow applications using KActivities to not crash even if no dbus server is around.
  
  e.g. Kate on macOS does immediately crash on opening any file ATM, as the calls have no checks if dbus is alive at all.
  With these checks, all is fine, thought no activities handling occurs, naturally.
  
  An other solution would be to just skip compiling kactivies on macOS, but on the other side I think guarding against the case of no dbus connection is around doesn't hurt.

TEST PLAN
  without patch: crash on file open in e.g. kate
  
  with path: file open works in kate

REPOSITORY
  R6 KActivities

REVISION DETAIL
  https://phabricator.kde.org/D9703

AFFECTED FILES
  src/lib/manager_p.cpp

To: cullmann, #frameworks, #kactivities
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180106/61a9c82a/attachment.html>


More information about the Kde-frameworks-devel mailing list