D6829: Add ability to use the new kauth helper in file ioslave
Chinmoy Ranjan Pradhan
noreply at phabricator.kde.org
Tue Jan 2 11:52:54 UTC 2018
chinmoyr updated this revision to Diff 24578.
chinmoyr added a comment.
1.Added method privilegeOperationUnitTestMode. This replaces the previous block of code which
tested the validity of the KAuth action by looking up the action in *.policy file. I think instead of looking
for some external files its better to test if the job has the flag for privilege operation set and has a
parent job as well (in case of subjob). The method requestPrivilegeOperation is there for this exact purpose.
So for the purpose of unit test checking return value of requestPrivilegeOperation should be
sufficient.
2. Fixed compilation issue on windows. (There was a mismatch in signature of execWithElavatedPrivileges)
3. Changed API version to 5.43
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6829?vs=20610&id=24578
BRANCH
6829
REVISION DETAIL
https://phabricator.kde.org/D6829
AFFECTED FILES
src/core/global.h
src/core/slavebase.cpp
src/core/slavebase.h
src/core/slaveinterface.cpp
src/core/slaveinterface.h
src/ioslaves/file/file.h
src/ioslaves/file/file_p.h
src/ioslaves/file/file_unix.cpp
src/ioslaves/file/file_win.cpp
To: chinmoyr, dfaure, #frameworks
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180102/b43dc552/attachment.html>
More information about the Kde-frameworks-devel
mailing list