D10857: Change qSort to std::sort in simplifiedUrlList

Mark Gaiser noreply at phabricator.kde.org
Wed Feb 28 17:51:47 UTC 2018


markg accepted this revision.
markg added a comment.


  +1, but wait till someone else had a look as well.

INLINE COMMENTS

> kdirmodel.cpp:42
>  
> -#include <algorithm>
> -

Don't you need to keep that one?
Nothing seems to be including <algorithm> (for std::sort at the very least) so i'm not sure why it would work at the moment without that header.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10857

To: jtamate, #frameworks, dfaure, markg
Cc: markg, apol, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180228/a4b095be/attachment.html>


More information about the Kde-frameworks-devel mailing list