D10551: autotest for crashing in KArchiveDirectory::addEntry
David Faure
noreply at phabricator.kde.org
Wed Feb 28 17:43:57 UTC 2018
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Thanks - almost there.
INLINE COMMENTS
> karchivetest.cpp:1172
> + int metaInfCount = 0;
> + for (const QString &entryName : zip.directory()->entries()) {
> + if (entryName.startsWith("META-INF")) {
This detaches the list, put it in a const local variable.
(standard range-for trap with Qt containers)
REVISION DETAIL
https://phabricator.kde.org/D10551
To: sandsmark, dfaure, apol
Cc: #frameworks, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180228/b50c57da/attachment.html>
More information about the Kde-frameworks-devel
mailing list