D10694: epubextractor: Handle multiple subjects better

[Michael Heidelbach]

michaelh added a comment.


  @mgallien : taglibextractor.cpp is very hard to read. Hopefully it is no longer.

INLINE COMMENTS

> epubextractor.cpp:94
>      }
>  
> +    value = fetchMetadataString(ePubDoc, EPUB_CREATOR);

Did you mean something like this?:

  const auto& values = fetchMetadata(ePubDoc, EPUB_SUBJECT);
  for (auto& value : values) {
          result->add(Property::Subject, value);
   }

It fails the test (of course). It it unclear to me how to handle `result.properties().value(Property::Subject)` and there is no example in the tests. They all compare against `QVariant::Type::String`. Do you have an example from elisa?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10694

To: michaelh, mgallien, dfaure
Cc: #frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, isidorov, nicolasfella, firef, andrebarros, alexeymin, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180228/f1c7deb5/attachment.html>