D10899: Don't make Headings 20% transparent, to match Kirigami

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
ngraham requested review of this revision.

REVISION SUMMARY
  We recently removed Kirigami Headings' slight transparency, after concluding that it looked inappropriate to have Headings with lighter text than their textual content. `PlasmaExtras.Heading` does the same thing, so we should make the same change here, both based on the inherent merits of the change, and also to maintain consistency with Kirigami.
  
  This also slightly improves matters for people who complain about poor text contrast throughout Plasma.

TEST PLAN
  Browsed System Settings; headings are now ever so slightly darker (or lighter, for users of Dark themes)
  
  Also, here are some befores-and-afters for a widget I'm working on that uses Headings. Before:
  
  After:
  
  It's subtle; you'll need to flip between the two with the arrow keys to see the difference, and may need to also zoom in ([meta] + [+] + [plus])

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  opaque-headers (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10899

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/Heading.qml

To: ngraham, #plasma
Cc: #frameworks, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180227/34aacf26/attachment.html>