D10826: Introduce DocumentId class

[Sune Vuorela]

svuorela added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in documentid.h:51-52
> Make a d poniter in exported class.

it depends on why it is exported. If it is exported just for unit test (and the header file not installed), then we don't need to have the mental and code wise overhead of a d-pointer.

If we know that it will never ever need to grow, we also don't need the overhead of a d-pointer. 
So it is a big "it depends", which I was also kind of trying to ask into earlier.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10826

To: michaelh, adridg, #baloo, #frameworks
Cc: anthonyfieroni, svuorela, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180226/5583267e/attachment.html>