D10870: [PackageUrlInterceptor] Don't rewrite "inline"
Kai Uwe Broulik
noreply at phabricator.kde.org
Mon Feb 26 14:40:27 UTC 2018
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
broulik requested review of this revision.
REVISION SUMMARY
When omitting the third "location" argument of `Qt.createQmlObject` it will instead use "inline" [1] as path and will run through the entire URL interceptor even logic.
[1] https://code.qt.io/cgit/qt/qtdeclarative.git/tree/src/qml/qml/v8/qqmlbuiltinfunctions.cpp#n1134
TEST PLAN
Task Manager no longer enters the complicated "I dont know what this is" guessing code path of the url interceptor
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D10870
AFFECTED FILES
src/plasmaquick/packageurlinterceptor.cpp
To: broulik, #plasma
Cc: #frameworks, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180226/4719414b/attachment.html>
More information about the Kde-frameworks-devel
mailing list