D10857: Change qSort to std::sort in simplifiedUrlList

Jaime Torres Amate noreply at phabricator.kde.org
Mon Feb 26 12:11:11 UTC 2018


jtamate created this revision.
jtamate added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
jtamate requested review of this revision.

REVISION SUMMARY
  qSort is depecreated in Qt5.
  But qSort is also quite slow compared to std::sort.
  
  There are 11 more uses of qSort in kio.

TEST PLAN
  Select 50.000 small files and press Shift-Supr.
  With qSort 11% of cpu
  F5730673: qSortOneTime.png <https://phabricator.kde.org/F5730673>
  
  Select 50.000 small files and press Shift-Supr, cancel and press Shift-Supr again.
  With std::sort 3.3% of cpu
  F5730676: stdSortTwoTimes.png <https://phabricator.kde.org/F5730676>

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10857

AFFECTED FILES
  src/widgets/kdirmodel.cpp

To: jtamate, #frameworks, dfaure
Cc: michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180226/13e26455/attachment.html>


More information about the Kde-frameworks-devel mailing list