D10537: Convert from old connect syntax to new one

David Faure noreply at phabricator.kde.org
Mon Feb 26 09:03:19 UTC 2018


dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> listjob.cpp:140
> +                    QObject::connect(job, &ListJob::entries, q,
> +                        [this](KIO::Job *job,const KIO::UDSEntryList &list) {gotEntries(job, list);} );
> +                    QObject::connect(job, &ListJob::subError, q,

missing space after comma
[it wasn't there in SIGNAL/SLOT for string normalization purposes, but here it's a lambda function, not a string anymore]

> listjob.cpp:142
> +                    QObject::connect(job, &ListJob::subError, q,
> +                        [this](KIO::ListJob *job,KIO::ListJob *ljob) {slotSubError(job, ljob);} );
> +

space after ','

> listjob.cpp:288
> +    QObject::connect(slave, &Slave::listEntries, q,
> +        [this](KIO::UDSEntryList list){ slotListEntries(list);} );
> +

const KIO::UDSEntryList &

> listjob.cpp:294
> +    QObject::connect(slave, &Slave::redirection, q,
> +        [this](QUrl url){ slotRedirection(url);} );
>  

const QUrl &

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10537

To: jtamate, #frameworks, dfaure
Cc: broulik, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180226/8351c7a5/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list