D10414: Add move semantics support to KIO::UDSEntry.

David Faure noreply at phabricator.kde.org
Sun Feb 25 20:02:32 UTC 2018


dfaure added inline comments.

INLINE COMMENTS

> dfaure wrote in udsentrytest.cpp:235
> That's rather overkill (and a wrong use of the QUrl API). You want to use QFileInfo for this.

The comment is marked as done, but the code that was pushed still uses QUrl.

> dfaure wrote in udsentrytest.cpp:269
> swap it around: what you test on the left, what you expect on the right. This makes error messages more readable.  (same above, of course)

Same here, this was not fixed in the commit that was pushed.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10414

To: markg, dfaure
Cc: bcooksley, apol, #frameworks, michaelh, kmorwinski
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180225/d59c846c/attachment.html>


More information about the Kde-frameworks-devel mailing list