D10826: Introduce DocumentId class

Michael Heidelbach noreply at phabricator.kde.org
Sun Feb 25 19:41:45 UTC 2018


michaelh added a comment.


  @svuorela: Thank you very much. I will try you suggestion as soon as I'm able to get the tests compiled.

INLINE COMMENTS

> svuorela wrote in documentid.h:34
> Does it need to be exported? Is things outside of the baloo engine need to access this? (or is it just avaliable for tests)
> 
> If it is public-public, you need to be careful about the class size and ensure you have enough bits to work with in the members.

I got linker errors without this, so ... err yes.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10826

To: michaelh, adridg, #baloo, #frameworks
Cc: svuorela, ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180225/93a7521d/attachment.html>


More information about the Kde-frameworks-devel mailing list