D10694: epubextractor: Handle multiple subjects better

Matthieu Gallien noreply at phabricator.kde.org
Sun Feb 25 15:15:29 UTC 2018


mgallien added a comment.


  In D10694#210509 <https://phabricator.kde.org/D10694#210509>, @michaelh wrote:
  
  > The only component I could find to be affected by this change is `baloo-widgets`. I have already adapted it to this change. And yes, it will handle both.
  >  It will take a some time to publish it because some other stuff has to get reviewed first.
  >  I you know of any component or application using the epub-extractor of KFileMetadata apart from baloo-widgets please let me know.
  
  
  I do understand that you have searched inside KDE hosted code. Still, you are modifying the behavior. To me, it is necessary to have a test that ensures that possible existing clients are not affected by your change. Could you add it ?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10694

To: michaelh, mgallien, dfaure
Cc: #frameworks, ashaposhnikov, michaelh, kmorwinski, spoorun, navarromorales, isidorov, nicolasfella, firef, andrebarros, alexeymin, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180225/4f245a27/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list