D10646: Support case-insensitive WordDetect

[jonathan poelen]

jpoelen added a comment.


  It seems that KTextEditor does not have the problem because KateHlWordDetect is based on KateHlStringDetect which uses the inSensitive parameter.

INLINE COMMENTS

> rule_p.h:249
>      QString m_word;
> +    Qt::CaseSensitivity m_caseSensitivity;
>  };

Yes, but it is in any case overwritten by doLoad(). StringDetect and others do not have this initialization either, should I also make the modification?
In fact, I do not think it's relevant because the analysis tools would no longer detect "uninitialized" variables in the case, for example, of calling doMatch before doLoad.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  word_insensitive

REVISION DETAIL
  https://phabricator.kde.org/D10646

To: jpoelen, dhaumann
Cc: dhaumann, #frameworks, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180219/60dc0485/attachment.html>