D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

Méven Car noreply at phabricator.kde.org
Mon Feb 19 18:02:22 UTC 2018


meven added a comment.


  It was suggested on IRC to hide this behavior behind a flag such as the jobFlag enum, so that it can be opt-in/opt-out in applications.
  
  We could consider changing the job state during the clean up, something like
  
    d->state == STATE_CLEANING_INCOMPLETE_FILE

INLINE COMMENTS

> anthonyfieroni wrote in copyjob.cpp:559
> Why only first not all?

I believe this is because files are copied in sequence, so at any given time only the first file is being copied.

Maybe you could use m_currentSrcURL to avoid accessing the iterator.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10663

To: dmitrio, #frameworks, dfaure
Cc: anthonyfieroni, meven, #frameworks, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180219/d6836fdd/attachment.html>


More information about the Kde-frameworks-devel mailing list