D10658: [UDisksDeviceBackend] Avoid double lookup
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Mon Feb 19 14:38:58 UTC 2018
apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> udisksdevicebackend.cpp:55
> {
> - if (s_backends.contains(udi)) {
> - DeviceBackend *backend = s_backends.value(udi);
> - s_backends.remove(udi);
> - delete backend;
> - }
> + delete s_backends.take(udi);
> }
Here it was triple look-up! ;)
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D10658
To: broulik, #frameworks, davidedmundson, apol
Cc: apol, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180219/2d9e35bd/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list