D10629: Avoid a double emitResult()

Jaime Torres Amate noreply at phabricator.kde.org
Mon Feb 19 10:19:27 UTC 2018


jtamate added a comment.


  In D10629#209358 <https://phabricator.kde.org/D10629#209358>, @broulik wrote:
  
  >
  
  
  I did a objdump -d to be sure:
  
  > dataengines/places/setupdevicejob.cpp
  
  setError is from KJob and it only sets a member value (d->error = errorCode;)
  
  > dataengines/mpris2/playeractionjob.cpp
  
  setErrorText is from KJob also and it only sets a member value (d->errorText = errorText;)
  
  > dataengines/applicationjobs/jobaction.cpp
  
  The same as the other two.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10629

To: jtamate, #frameworks, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180219/38a58793/attachment.html>


More information about the Kde-frameworks-devel mailing list