D10578: balooctl monitor: Wait for dbus interface

David Faure noreply at phabricator.kde.org
Mon Feb 19 08:24:02 UTC 2018


dfaure added inline comments.

INLINE COMMENTS

> monitorcommand.cpp:53
> +    while (!m_dbusInterface->isValid()) {
> +        QThread::msleep(50);
> +        m_dbusInterface->disconnect();

Hmm, why not just use QDbusServiceWatcher's signals, to connect to serviceRegistered, if the service isn't available when we start?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10578

To: michaelh, dfaure, alexeymin
Cc: cfeck, alexeymin, #frameworks, ashaposhnikov, michaelh, spoorun, nicolasfella
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180219/e027d178/attachment.html>


More information about the Kde-frameworks-devel mailing list